Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update verification tag retrieval tests to enhance error handling #1842

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

kseghair
Copy link
Contributor

@kseghair kseghair commented Jan 16, 2025

Do not send 403 errors to Sentry in verification tag retrieval

Update verification tag retrieval tests to enhance error handling

  • Modified the "handles 403 Forbidden error gracefully" test to throw an HttpClientError with a 403 status code.
  • Updated the "handles 404 Not Found error" test to throw an HttpClientError with a 404 status code.
  • Adjusted the "stops when token retrieval fails" test to throw an HttpClientError with a 500 status code and added an assertion to ensure Sentry.captureException is called.

Update PHP-CS-Fixer action in GitHub workflow

  • Changed the PHP-CS-Fixer command from a direct run to using the PrestaShop GitHub Action for PHP-CS-Fixer.

@kseghair kseghair self-assigned this Jan 16, 2025
@kseghair kseghair requested a review from a team as a code owner January 16, 2025 10:14
@kseghair kseghair merged commit 3c89a69 into master Jan 17, 2025
37 of 38 checks passed
@kseghair kseghair deleted the reduce-error-reporting branch January 17, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants